Re: Kernel 2.4 and 2.6 disagree about NFSEXP_CROSSMNT - upward incompatibility, please fix

From: Andrew Morton (akpm@osdl.org)
Date: Thu Jul 31 2003 - 17:05:48 EST


Chip Salzenberg <chip@pobox.com> wrote:
>
> According to Steve Dickson:
> > It seems in nfs-utils-1.05 (actually it happen in 1.0.4)
> > the NFSEXP_CROSSMNT define was changed to 0x4000 ....
>
> This looks like an actual kernel incompatibility 2.4 <-> 2.6, as
> the 2.4 and 2.6 trees disagree about the value of NFSEXP_CROSSMNT.

yup.

> > So could please add this patch that simply switchs the bits
> > so NFSEXP_CROSSMNT stays the same and the new NFSEXP_NOHIDE define
> > gets the higher bit?
>
> And 2.6's include/linux/nfsd/export.h needs the same fix. This needs
> to go in before the 2.6.0 release or nfs-utils is in deep kimchi.

Like this?

diff -puN include/linux/nfsd/export.h~nfs-flags-untangle include/linux/nfsd/export.h
--- 25/include/linux/nfsd/export.h~nfs-flags-untangle Thu Jul 31 15:04:25 2003
+++ 25-akpm/include/linux/nfsd/export.h Thu Jul 31 15:04:49 2003
@@ -35,12 +35,12 @@
 #define NFSEXP_UIDMAP 0x0040
 #define NFSEXP_KERBEROS 0x0080 /* not available */
 #define NFSEXP_SUNSECURE 0x0100
-#define NFSEXP_NOHIDE 0x0200
+#define NFSEXP_CROSSMNT 0x0200
 #define NFSEXP_NOSUBTREECHECK 0x0400
 #define NFSEXP_NOAUTHNLM 0x0800 /* Don't authenticate NLM requests - just trust */
 #define NFSEXP_MSNFS 0x1000 /* do silly things that MS clients expect */
 #define NFSEXP_FSID 0x2000
-#define NFSEXP_CROSSMNT 0x4000
+#define NFSEXP_NOHIDE 0x4000
 #define NFSEXP_ALLFLAGS 0x7FFF
 
 

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:52 EST