Re: dm: v4 ioctl interface (was: Re: Linux v2.6.0-test2)

From: Geert Uytterhoeven (geert@linux-m68k.org)
Date: Thu Jul 31 2003 - 03:04:56 EST

On Wed, 30 Jul 2003, Andrew Morton wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > o dm: v4 ioctl interface
> >
> > This interface code contains a local `resume()' routine, which conflicts with
> > the `resume()' defined by many architectures in <asm/*.h>. The patch below
> > fixes this by renaming the local routine to `do_resume()'.
>
> ok..
>
> > However, after this change it still doesn't compile...
>
> It does for me. What is it doing wrong for you?

It fails in finding DM_DIR and other related definitions.

Apparently a very important include file is missing, the patch below fixes
this. I don't see how it could compile on ia32 though (I'm cross-compiling for
m68k):

--- linux-2.6.0-test2/drivers/md/dm-ioctl-v4.c.orig Wed Jul 30 23:17:16 2003
+++ linux-2.6.0-test2/drivers/md/dm-ioctl-v4.c Thu Jul 31 10:02:13 2003
@@ -14,6 +14,7 @@
 #include <linux/blk.h>
 #include <linux/slab.h>
 #include <linux/devfs_fs_kernel.h>
+#include <linux/dm-ioctl.h>
 
 #include <asm/uaccess.h>
 

Gr{oetje,eeting}s,

                                                Geert 

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:49 EST