Re: [PATCH] linux-2.6.0-test2 h8300 archtecure support update (1/6)

From: Sam Ravnborg (sam@ravnborg.org)
Date: Tue Jul 29 2003 - 14:20:56 EST


On Mon, Jul 28, 2003 at 11:18:23PM +0900, Yoshinori Sato wrote:
> BOARD := $(board-y)

There is no need for renaming this variable, it is only reference three
times, so board-y would be fine.
Same goes for MODEL.

> +
> +vmlinux.bin: vmlinux
> + $(OBJCOPY) -Obinary $< $@
> +
> +vmlinux.srec: vmlinux
> + $(OBJCOPY) -Osrec $< $@
The above is more suited for a seperate boot/ directory.

Example:
boot := arch/$(ARCH)/boot
vmlinux.srec vmlinux.bin: vmlinux
        $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@

archclean:
        $(Q)$(MAKE) $(clean)=$(boot)

(The current archclean rule is plain wrong).

And in boot/Makefile

OBJCOPYFLAGS_vmlinux.srec := -Osrec
OBJCOPYFLAGS_vmlinux.bin := -Obinary
$(obj)/vmlinux.srec $(obj)/vmlinux.bin: vmlinux FORCE
        $(call if_changed,objcopy)
        @echo ' Kernel: $@ is ready'

targets += vmlinux.srec vmlinux.bin

> +
> +define archhelp
> + echo 'vmlinux.bin - Create raw binary'
> + echo 'vmlinux.srec - Create srec binary'
> +endef
OK - shall stay in arch/$(ARCH)/Makefile

> +
> +CLEAN_FILES += arch/$(ARCH)/vmlinux.bin arch/$(ARCH)/vmlinux.srec

Replaced by targets assignment in boot/Makefile.
But you shall add files related to asm-offsets:
CLEAN_FILES += include/asm-$(ARCH)/asm-offsets.h

        Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:42 EST