Re: [patch] ixj.c: EXPORT_SYMBOL of static functions

• Next message: Ronald Bultje: "2.4.21 doesn't boot: /bin/insmod.old: file not found"
• Previous message: Torsten Foertsch: "Re: [PATCH] Disable Trackpad while typing"
• In reply to: Alan Cox: "Re: [patch] ixj.c: EXPORT_SYMBOL of static functions"
• Next in thread: Rusty Russell: "Re: [patch] ixj.c: EXPORT_SYMBOL of static functions"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 22 Jun 2003, Alan Cox wrote:

> On Sul, 2003-06-22 at 02:02, Adrian Bunk wrote:
> > drivers/telephony/ixj.c EXPORT_SYMBOL's two static functions.
> >
> > Does this make any sense or is the patch below OK?
>
> It's meant to export them. An exported static function is visible to
> other modules.

The exported functions shouldn't normally be declared static though,
because that means that they will not be available to other modules in the
built-in case.

So most likely the correct fix is to remove the "static". However,
ixj_register() still doesn't seem to be used anywhere at all, at least not
by in-tree modules.

--Kai

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Ronald Bultje: "2.4.21 doesn't boot: /bin/insmod.old: file not found"
• Previous message: Torsten Foertsch: "Re: [PATCH] Disable Trackpad while typing"
• In reply to: Alan Cox: "Re: [patch] ixj.c: EXPORT_SYMBOL of static functions"
• Next in thread: Rusty Russell: "Re: [patch] ixj.c: EXPORT_SYMBOL of static functions"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jun 23 2003 - 22:00:38 EST