Re: [PATCH] nfs_unlink() race (was: nfs_refresh_inode: inode number mismatch)

From: Trond Myklebust (trond.myklebust@fys.uio.no)
Date: Mon Jun 09 2003 - 11:40:43 EST


>>>>> " " == Linus Torvalds <torvalds@transmeta.com> writes:

> I think your #1 is "obviously correct", but the fact that it
> breaks rmdir sounds like a bummer. However, since it only
> breaks rmdir when silly-renames exist - and since silly-renames
> should only happen when you have a file descriptor still open -
> I'd be inclined to say that this is the right behaviour.

I agree.

If people prefer 'rm -rf' correctness instead of unlinked-but-open,
then we could do that by changing the behaviour of 'unlink' on a
silly-deleted filed. Currently it returns EBUSY, but we could just as
well have it complete the unlink, and mark the inode as being stale...

Cheers,
   Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:21 EST