Re: [PATCH] swap 13/13 may_enter_fs?

From: Bill Davidsen (davidsen@tmr.com)
Date: Thu Mar 27 2003 - 09:55:08 EST


On Wed, 26 Mar 2003, Hugh Dickins wrote:

> On Wed, 26 Mar 2003, Bill Davidsen wrote:
> >
> > Unless there's a subtle difference in functionality here that I'm missing,
> > you are doing the same thing in a larger and slower way, and the logic is
> > less clear.
> >
> > Is there some benefit I'm missing?
>
> No, it's just that Andrew finds the logic clearer when written out his way.

Looking a code generated from fragments, I don't think gcc shares that
opinion ;-) Actually I find it more obvious with the ? notation, and it
prevents someone in the future changing the logic in one line of code when
it needs to change in both.

Oh well, I expect the ? form to stay, since it uses less cache.

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:28 EST