So you said you had a userland test harness?
Some problems I've seen browsing the code:
(1) You make no provision for sections to be loaded in any order
except the order they appear in the object file. This is bad.
You *really* need to replicate something akin to obj_load_order_prio
from the 2.4 modutils, lest small data sections be placed incorrectly
wrt the GOT section.
(2) I see no provision for small COMMON symbols to be placed in the
.sbss section rather than in the .bss section. Unless you are
sorting your allocation of COMMON symbols by size, which I also
don't see, this can result in link errors due to SCOMMON symbols
not being reachable from the GP.
These will affect at least Alpha, IA-64, and MIPS.
(3) Alpha and MIPS64 absolutely require that the core and init allocations
are "close" (within 2GB). I don't see how this can be guaranteed with
two different vmalloc calls.
Allocating the two together would also allow us to only have
one flush_icache_range call. Not that I consider module
loading particularly performance critical, but it'd be nice.
That's all I can think of at the moment.
r~
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:34 EST