Re: and nicer too - Re: [PATCH] epoll more scalable than poll

From: Davide Libenzi (davidel@xmailserver.org)
Date: Mon Oct 28 2002 - 19:08:04 EST


On Mon, 28 Oct 2002, John Gardiner Myers wrote:

> bert hubert wrote:
>
> >The interface is also lovely:
> >
> >
> The code you wrote has the standard epoll race condition. If the file
> descriptor 's' becomes readable before the call to sys_epoll_ctl,
> sys_epoll_wait() will never return the socket. The connection will hang
> and the file descriptor will effectively leak.
>
> As you have amply demonstrated, the current epoll API is error prone.
> The API should be fixed to test the poll condition and, if necessary,
> drop an event upon insertion to the set.

So, please don't use :

        free((void *) rand());

free() is flawed !! Be warned !!

- Davide

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Oct 31 2002 - 22:00:40 EST