Re: [BK PATCH] pcibios_* removals for 2.5.40

From: Greg KH (greg@kroah.com)
Date: Fri Oct 04 2002 - 11:59:55 EST


On Fri, Oct 04, 2002 at 09:33:08AM -0700, Linus Torvalds wrote:
>
> On Thu, 3 Oct 2002, Greg KH wrote:
> >
> > Here's some changesets that remove the pcibios_find_class(),
> > pci_find_device(), and pcibios_present() functions. These functions
> > have been marked as obsolete since the 2.2 kernel, so it's about time
> > that we removed them.
>
> They are still in use by a lot of drivers..

Not all that many drivers:

pcibios_find_class is used in the following files:
         drivers/net/aironet4500_card.c
        drivers/net/wan/lmc/lmc_main.c

The lmc driver has only had 1 janitor cleanup in all of 2.5, and the
aironet4500_card driver has had only trivial changes too. But I'll try
to fix them up, if anyone uses them, and I break them, I'm sure I'll
hear about it :)

pcibios_find_device is used in only 11 different drivers. I'll go clean
up those instances too.

And I thought I caught all of the places that pcibios_present() was used
already, but I'll go verify that again.

> I hate to break even more drivers at this point in 2.5.x, and so quite
> frankly I'd rather just do this in early 2.7.x instead. Unless
> somebody really steps up to the plate and also fixes the drivers
> ("it's a ton of fun, and imagine all the adoration you'll get from
> teenage girls/boys/ninja turtles for doing it")

I'll clean them all up and resubmit these changes to you when finished.

thanks,

greg k-h
(who can't wait for the ninja turtles to finally start adoring him!)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Oct 07 2002 - 22:00:46 EST