Re: [PATCH] Re: Disk IO statistics still buggy

From: Jochen Suckfuell (jo-lkml@suckfuell.net)
Date: Mon Jul 22 2002 - 10:11:30 EST


Hi!

I'm just curious about the status: will this patch be included in 2.4.19
final?

On Thu, Jul 11, 2002 at 06:27:25PM -0300, Marcelo Tosatti wrote:
>
> Christoph,
> Can you take a look at this one ?
>
> On Tue, 9 Jul 2002, Jochen Suckfuell wrote:
> > The accounting was done on a copy of the request _after_ the request has
> > been dequeued and the irq_request_lock released. I fixed this by taking
> > this lock again while calling the accounting function (see the patch
> > below).
> >
> > [...]
> >
> > --- linux/drivers/scsi/scsi_lib.c Mon Jul 8 16:15:27 2002
> > +++ linux_work/drivers/scsi/scsi_lib.c Tue Jul 9 17:56:39 2002
> > @@ -426,7 +426,9 @@
> > if (req->waiting != NULL) {
> > complete(req->waiting);
> > }
> > + spin_lock_irq(&io_request_lock);
> > req_finished_io(req);
> > + spin_unlock_irq(&io_request_lock);
> > add_blkdev_randomness(MAJOR(req->rq_dev));
> >
> > SDpnt = SCpnt->device;

Bye
Jochen

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:39 EST