On Sat, 6 Jul 2002, Keith Owens wrote:
> The valid combination of CONFIG_NET=n, CONFIG_LLC undefined incorrectly
> builds ext8022.o and gets unresolved references because there is no
> network code. Detected by kbuild 2.5, not detected by the existing
> build system.
>
> Index: 25.1/net/core/Makefile
> --- 25.1/net/core/Makefile Wed, 19 Jun 2002 14:11:35 +1000 kaos (linux-2.5/p/c/50_Makefile 1.4 444)
> +++ 25.1(w)/net/core/Makefile Sat, 06 Jul 2002 18:27:16 +1000 kaos (linux-2.5/p/c/50_Makefile 1.4 444)
> @@ -16,7 +16,7 @@ obj-$(CONFIG_FILTER) += filter.o
>
> obj-$(CONFIG_NET) += dev.o dev_mcast.o dst.o neighbour.o rtnetlink.o utils.o
>
> -ifneq ($(CONFIG_LLC),n)
> +ifneq ($(subst n,,$(CONFIG_LLC)),)
> obj-y += ext8022.o
> endif
Makes sense to me. However, the CONFIG_ variables used in the Makefiles
are never "n", they are "y", "m" or undefined.
In Config.in scripts you have to cater for "n" or "", and I've seen
various people on l-k carry this behavior into the Makefiles, but there
it's unnecessary for all I can tell.
So
ifdef CONFIG_LLC
obj-y += ext8022.o
endif
should do the job just fine.
--Kai
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:36 EST