Re: Can't compile 2.4.3 with agcc

From: David Woodhouse (dwmw2@infradead.org)
Date: Mon Apr 23 2001 - 15:46:09 EST

alan@lxorguk.ukuu.org.uk said:
> At least make the final printk a panic..

ingo.oeser@informatik.tu-chemnitz.de said:
> replace this with panic() please.

I considered this, but in the end decided to copy the method from a few
lines above, which triggers in the case of no FPU and no FPE. I wasn't sure
if there was a reason why we shouldn't panic() here.

RCS file: /inst/cvs/linux/include/asm-i386/bugs.h,v
retrieving revision 1.2.2.16
diff -u -r1.2.2.16 bugs.h
--- include/asm/bugs.h 2001/01/18 13:56:53 1.2.2.16
+++ include/asm/bugs.h 2001/04/23 20:40:57
@@ -80,8 +80,9 @@
          * Verify that the FXSAVE/FXRSTOR data will be 16-byte aligned.
          */
         if (offsetof(struct task_struct, thread.i387.fxsave) & 15) {
- extern void __buggy_fxsr_alignment(void);
- __buggy_fxsr_alignment();
+ printk(KERN_EMERG "FXSAVE data are not 16-byte aligned in task_struct.\n");
+ printk(KERN_EMERG "This is usually caused by a buggy compiler (perhaps pgcc?)\n");
+ panic("Cannot continue.");
         }
         if (cpu_has_fxsr) {
                 printk(KERN_INFO "Enabling fast FPU save and restore... "); 

--
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Apr 23 2001 - 21:00:47 EST