Re: cpu_has_fxsr or cpu_has_xmm?

From: H. Peter Anvin (hpa@zytor.com)
Date: Fri Feb 23 2001 - 01:11:52 EST


Followup to: <200102230538.VAA17793@mail23.bigmailbox.com>
By author: "Quim K Holland" <qkholland@my-deja.com>
In newsgroup: linux.dev.kernel
>
> I've been looking at various -ac patches for the last couple of
> weeks and have been wondering why only this piece of difference
> still remains between Linus' 2.4.2 and Alan's -ac2. All the other
> diffs in i387.c from 2.4.1-ac2 seem to have been merged into Linus
> tree at around 2.4.2-pre1. Could anybody explain it for me please?
>
> --- linux.vanilla/arch/i386/kernel/i387.c Thu Feb 22 09:05:35 2001
> +++ linux.ac/arch/i386/kernel/i387.c Sun Feb 4 10:58:36 2001
> @@ -179,7 +179,7 @@
>
> unsigned short get_fpu_mxcsr( struct task_struct *tsk )
> {
> - if ( cpu_has_fxsr ) {
> + if ( cpu_has_xmm ) {
> return tsk->thread.i387.fxsave.mxcsr;
> } else {
> return 0x1f80;
>

IMO, XMM is correct here; FXSR is incorrect. Linus?

        -hpa

-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Feb 23 2001 - 21:00:29 EST