Re: [PATCH] Athlon-SMP compiles & runs. inline fns honored.

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Sat Feb 10 2001 - 16:29:45 EST


Tom Leete wrote:
>
> Hi Alan
>
> I found one way to break the circularity. The association of type and struct
> definitions with interlocking inline functions caused the problem. This
> extracts task_struct from linux/sched.h to its own header,
> linux/task_struct.h. There are a few modifications elsewhere to support
> this. I'm not sure all the changes were necessary, but they are working as I
> write:
[long patch snipped]

Ouch. What about un-inlining in_interrupt() for all SMP cases? Reduces
code size just a bit, and function calls aren't very expensive on SMP
machines IMHO... (and as a side effect solves this problem...)

        Jeff

-- 
Jeff Garzik       | "You see, in this world there's two kinds of
Building 1024     |  people, my friend: Those with loaded guns
MandrakeSoft      |  and those who dig. You dig."  --Blondie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Feb 15 2001 - 21:00:16 EST