Ingo Oeser wrote:
>
> On Fri, Nov 03, 2000 at 10:12:31PM -0500, Jeff Garzik wrote:
> > But if you are going to eliminate info->vxi_base, it seems like that
> > would flush out all direct de-refs, whether they are buried in an
> > obscure macro or not. And if you find all that crap, you might as well
> > use readb/writel at that point...
> >
> > info->registers[0x7FF] = newvalue;
> > becomes
> > writel(newvalue, &info->registers[0x7FF]);
> > and
> > regval = info->registers[0x7FF];
> > becomes
> > regval = readl(&info->registers[0x7FF]);
>
> Wasn't this the clean and recommended interface anyway?
> (ref. IO-mapping.txt:150)
Absolutely! We are talking about an old driver, though, and due
consideration has to be given to not breaking existing code :)
Jeff
-- Jeff Garzik | Dinner is ready when Building 1024 | the smoke alarm goes off. MandrakeSoft | -/usr/games/fortune - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Nov 07 2000 - 21:00:15 EST