Re: [PATCH] Fix SCSI proc oops

From: Torben Mathiasen (torben@kernel.dk)
Date: Sun Oct 15 2000 - 04:19:24 EST


On Sat, Oct 14 2000, Linus Torvalds wrote:
>
>
> On Sat, 14 Oct 2000, David S. Miller wrote:
> >
> > The loop would be a no-op but the remove_proc_entry call would not.
> > Perhaps you didn't notice that there too? It's pretty close to the
> > loop :-)
>
> Ok.
>
> In fact, it's in the _wrong_ part.
>
> That remove_proc_entry() should be there in the same place where we remove
> the entry in teh list, wouldn't you say? Makes tons more sense that way,
> doesn't crash, and is understandable.
>

It seems reasonable. We'd been thinking of makeing proc_name part of the
host structure, but no need for that if we just do the above.

-- 
Torben Mathiasen <tmm@kernel.dk>
Linux ThunderLAN maintainer 
http://tlan.kernel.dk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Oct 15 2000 - 21:00:28 EST