Re: [PATCH] Fix SCSI proc oops

From: Linus Torvalds (torvalds@transmeta.com)
Date: Thu Oct 12 2000 - 14:26:08 EST


On Thu, 12 Oct 2000, Torben Mathiasen wrote:
>
> Attached patch should fix the oops's people have been getting
> while using /proc/scsi.

This patch makes no sense. Why

        if (!present)

when that is obviously the wrong way around.

I'm sure it fixes an oops - I just want to understand why the test is the
wrong way around, and why this patch is as it is. I have this suspicion
that you're hiding the real bug which would be to do this in another place
completely.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Oct 15 2000 - 21:00:23 EST