Re: 2.4.0-test9-pre7: partitioning code broken?

From: Andries Brouwer (aeb@veritas.com)
Date: Thu Sep 28 2000 - 11:08:48 EST


On Thu, Sep 28, 2000 at 04:18:00PM +0100, Tigran Aivazian wrote:
> Hi Andries,
>
> I just noticed that this boot message looks very strange:
>
> SCSI device sda: 1039329 512-byte hdwr sectors (532 MB)
> sda: sda1 sda1

Yes, no doubt because of the fragment of a patch for fs/partitions/check.c:

@@ -181,6 +191,10 @@
                printk(" p%d", (minor & ((1 << hd->minor_shift) - 1)));
        else
                printk(" %s", disk_name(hd, minor, buf));
+ if (hd->major >= COMPAQ_CISS_MAJOR+0 && hd->major <= COMPAQ_CISS_MAJOR+7)
+ printk(" p%d", (minor & ((1 << hd->minor_shift) - 1)));
+ else
+ printk(" %s", disk_name(hd, minor, buf));
 #endif
 }

that someone added for COMPAQ_CISS stuff. As you can see it causes
an additional printk() in the non-COMPAQ_CISS case.
(But this bug has been discussed here already; if it is not fixed
in test9-pre8 or so I'll resubmit the fix.)

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 30 2000 - 21:00:22 EST