Re: Linux 2.2.18pre11

From: David Rees (dbr@spoke.nols.com)
Date: Thu Sep 28 2000 - 11:07:46 EST


On Thu, Sep 28, 2000 at 04:13:24AM -0500, Jeff Garzik wrote:
>
> On Thu, 28 Sep 2000, Arjan van de Ven wrote:
>
> > In article <20000928000438.A3779@spoke.nols.com> you wrote:
> > > I'm getting this compile time error on 2.2.18pre11:
> >
> > > drivers/usb/usbdrv.o: In function `usb_init':
> > > drivers/usb/usbdrv.o(.text+0x6deb): undefined reference to `uhci_init'
> >
> > The patch below should fix that.
>
> No it doesn't.... read the usb/uhci code. It uses initcalls. The
> solution is to remove call to uhci_init() in usb_init().

Ah, is this the correct fix, then? I actually booted this one (I never
booted the other patch, just compiled it, and it works for me. :-)

-Dave

--- linux/drivers/usb/usb-core.c.orig Thu Sep 28 08:44:59 2000
+++ linux/drivers/usb/usb-core.c Thu Sep 28 08:47:13 2000
@@ -60,12 +60,6 @@
        usb_hub_init();

 #ifndef CONFIG_USB_MODULE
-#ifdef CONFIG_USB_UHCI
- uhci_init();
-#endif
-#ifdef CONFIG_USB_UHCI_ALT
- uhci_init();
-#endif
 #ifdef CONFIG_USB_OHCI
        ohci_hcd_init();
 #endif

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 30 2000 - 21:00:22 EST