"Phillips, Mike" wrote:
> >* The "paragraph" of code right below the call to pci_enable_device can
> >be replaced with a simple call to pci_set_master.
> >pci_enable_device+pci_set_master enable all the PCI_COMMAND bits needed
> >for operation.
>
> Oh yes you do, otherwise the PowerPC won't activate the card properly, this
> may be a problem with the PPC arch rather that the driver though.
have you checked this with recent kernels? In response to a patch sent
by me to linuxppc-dev, someone (planb maintainer?) said PPC was now
working in this regard. Thanks for pointing out this issue, I'm very
interested in getting a definite answer on this point.
> Jeff, I know you've taken on the responsibility for the ethernet drivers,
> and approve of what Arnaldo is doing, but it would have been nice to review
> the changes before they were posted to the mailing list. I'm working through
> some issues with the driver on certain machines at the moment and when this
> is fixed I was going to update the driver with the new pci api's, also the
> driver may need slight mods to work with the new cardbus version of the
> chipset which I was also going to include.
Posting to the list doesn't imply that a patch will be included by Linus
necessarily, and we are 100% agreed that all patches need to be sent to
driver maintainers. I disagree that patches should be hidden from the
list when they include obvious fixes, though, and I don't see anything
wrong with a public review of a patch. Reviews tend to help people
learn the kernel interfaces, both the patch author and general lkml
audience.
And though appearances are sometimes to the contrary, I don't claim to
be the maintainer of the net drivers. DaveM, Alexey, and the others are
far more influential in the actual design. In addition to maintaining a
few drivers, I mainly play the role of the kernel janitor, sweeping out
some of the bitrot now and again.. :)
Jeff
-- Jeff Garzik | Building 1024 | Andre the Giant has a posse. MandrakeSoft, Inc. |- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Aug 15 2000 - 21:00:19 EST