OK, now it's another day and the morning coffee has kicked in and
everything always look better after some gentle reflection. :)
> have you checked this with recent kernels? In response to a patch sent
> by me to linuxppc-dev, someone (planb maintainer?) said PPC was now
> working in this regard. Thanks for pointing out this issue, I'm very
> interested in getting a definite answer on this point.
I'll ask my ppc guy if the changes make a difference.
> Posting to the list doesn't imply that a patch will be included by Linus
> necessarily, and we are 100% agreed that all patches need to be sent to
> driver maintainers. I disagree that patches should be hidden from the
> list when they include obvious fixes, though, and I don't see anything
> wrong with a public review of a patch. Reviews tend to help people
> learn the kernel interfaces, both the patch author and general lkml
> audience.
Hmmm, maybe, maybe not, we have a separate mailing list and web site for
all the token ring related stuff where everything gets posted, discussed
and put up for general ridicule. My concern with posting stuff directly to
the kernel list is that changes may get applied to the driver and then
the driver maintainer either has to work with the patches or try to get
them reversed/changed making more work for the maintainer and for Alan/
Linus.
Either way Arnaldo has sent me some more code to fix up the other stuff in
the driver, most of this looks correct but I also want to fix all the module
stuff as well, the horribleness in there goes back to the days when
init_trdev did not work sufficiently for the drivers and the dev->priv
did not get aligned on a wide enough boundary.
So, I'll take the patch, make some more alterations, get my ppc guy to
test the change and then put the patch to be applied.
Mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Aug 15 2000 - 21:00:21 EST