Re: 2.2.16 md botch; please revert

From: Holger.Smolinski@de.ibm.com
Date: Fri Jun 09 2000 - 09:00:07 EST


Folks,
Sorry for any inconvenience with the md patch.
The problem on S/390 systems is, that we have
blocksizes deviating from the nice 1024 at PCs,
which caused md not to work with 2k or 4k devices
underlying. Hence reverting the patch will cause
problems on S/390...
btw.: has anybody ever tried md on a MO device
or something similar with blocksize of 2k and above?

The patch below limits the md_blocksize
to PAGE SIZE, which should at least keep the buffer
cache working...

diff -u -r1.2 md.c
--- drivers/block/md.c 2000/05/03 14:37:31 1.2
+++ drivers/block/md.c 2000/06/09 13:18:51
@@ -447,6 +447,9 @@
   factor = min = 1 << FACTOR_SHIFT(FACTOR((md_dev+minor)));

   md_blocksizes[minor] <<= FACTOR_SHIFT(FACTOR((md_dev+minor)));
+ if ( md_blocksizes[minor] > PAGE_SIZE ) {
+ md_blocksizes[minor] = PAGE_SIZE;
+ }

   for (i=0; i<md_dev[minor].nb_dev; i++)
     if (md_dev[minor].devices[i].size<min)

Gruesse / Regards

Dr. Holger Smolinski
Linux for S/390 Design & Development,
IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, D-71032 Boeblingen
Phone/FAX: +49 7031 16 (x902) - 4652/3456

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jun 15 2000 - 21:00:18 EST