2.2.16 md botch; please revert

From: Chip Salzenberg (chip@valinux.com)
Date: Thu Jun 08 2000 - 15:17:32 EST


The otherwise excellent (!) 2.2.16 patch includes a change to
drivers/block/md.c that breaks my raid0 setup. The change sets the md
device's block size to the RAID chunk size. Unfortunately, that causes
a total failure when the chunk size is larger than PAGE_SIZE, which it
is in my case (16K chunks, 4K page size).

Here is a patch that reverts the 2.2.16 change and makes it work for
me again. I'm curious to know what the change was supposed to do....

Index: drivers/block/md.c
*************** static int do_md_run (int minor, int rep
*** 447,452 ****
    factor = min = 1 << FACTOR_SHIFT(FACTOR((md_dev+minor)));
    
- md_blocksizes[minor] <<= FACTOR_SHIFT(FACTOR((md_dev+minor)));
-
    for (i=0; i<md_dev[minor].nb_dev; i++)
      if (md_dev[minor].devices[i].size<min)
--- 447,450 ----

-- 
Chip Salzenberg              - a.k.a. -              <chip@valinux.com>
"I wanted to play hopscotch with the impenetrable mystery of existence,
    but he stepped in a wormhole and had to go in early."  // MST3K

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jun 15 2000 - 21:00:16 EST