James Sutherland wrote:
>
> On Tue, 6 Jun 2000, Alan Cox wrote:
>
> > > > using code duplication. Give us a license to change buffer.c code to be more
> > > > general and we will.
> > >
> > > A license? buffer.c is GPLed, surely, along with the rest of the kernel.
> > > What's the problem?
> >
> > Different meaning . Linus wants journalling code not to interfere with the
> > core buffer.c code. So that given a problem you can see if its journalling
> > or non journalling and so that non journalling people dont get bitten
> >
> > Its a modularity thing
>
> Ahhh... IC. Do you know if using #ifdefs would be acceptable?? Creating an
> extended buffer.c which compiles "normally", with no changes, but compiles
> with -DJOURNALSUPPORT to give buffer-j.o would avoid at least the source
> duplication, easing maintenance. Alternatively, move most of the common
> code to buffer-main.c, keeping buffer.c compiling as it does now (but
> using some code from buffer-main.c) and creating a new buffer-journal.c
> which contains the journalled version?
>
> James.
Linus hates ifdefs....
We'd love to use them all over buffer.c if he didn't....
Hans
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Jun 07 2000 - 21:00:26 EST