Re: [one more PATCH] Re: Old HD driver does not compile in 2.3.99pre9-2

From: Andries Brouwer (aeb@veritas.com)
Date: Mon May 22 2000 - 04:34:24 EST


On Mon, May 22, 2000 at 10:13:06AM +0200, Andrzej Krzysztofowicz wrote:

> > So, Andrzej Krzysztofowicz must either change BIOS setup,
> > or add "hd=16383,16,63" or so (the actual values!) on the
> > kernel command line. The patch below will make sure that
> > the command line is actually read.
>
> Is there any reason for introducing another __setup function instead of
> modifying the original hd_setup ?
> hd_setup is not used for anything else.
>
> Moreover:
> - I do not see any reason for ints[6]. ints[4] should be enough as
> only three parameters are allowed.
> - shouldn't ide.c driver also accept these parameters ?

Since you ask:
New setup versus changing prototype of old one?
 Keeping the diff small and obvious.
The 6 was for "hd=cyls,heads,sects[,wpcom[,irq]]".
The ide driver already accepts lots of parameters.

Andries

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue May 23 2000 - 21:00:21 EST