> > > So, Andrzej Krzysztofowicz must either change BIOS setup,
> > > or add "hd=16383,16,63" or so (the actual values!) on the
> > > kernel command line. The patch below will make sure that
> > > the command line is actually read.
> >
> > Is there any reason for introducing another __setup function instead of
^^^^^^^^^^
> > modifying the original hd_setup ?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > hd_setup is not used for anything else.
> >
> > Moreover:
> > - I do not see any reason for ints[6]. ints[4] should be enough as
> > only three parameters are allowed.
> > - shouldn't ide.c driver also accept these parameters ?
>
> Since you ask:
> New setup versus changing prototype of old one?
> Keeping the diff small and obvious.
Diff size would be rather the same. New unnecessary functions would not make
it clearer, IMHO. Is this method recomended by Linus ? Did you do this for
any kind of "backwards compatibility" ?
> The 6 was for "hd=cyls,heads,sects[,wpcom[,irq]]".
hd.c hd_setup():
if (ints[0] != 3)
return;
So the last 2 parameters won't work... Where did you found them ?
This document seems to be out-of-date.
ide.c parse_options():
(!strncmp(line,"hd",2) && line[2] != '='))
(void) ide_setup(line);
So ide.c totally ignores "hd=" parameter. Check it...
> The ide driver already accepts lots of parameters.
This one is not among them...
Regards
Andrzej
-- ======================================================================= Andrzej M. Krzysztofowicz ankry@mif.pg.gda.pl tel. (0-58) 347 14 61 Wydz.Fizyki Technicznej i Matematyki Stosowanej Politechniki Gdanskiej- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue May 23 2000 - 21:00:21 EST