Re: [PATCH] small rtc.c fix

• Next message: James Simmons: "Re: [linux-fbdev] Re: [PATCH] updated Mips Magnum frame buf"
• Previous message: Lorenzo Allegrucci: "Re: A variant of mlockall()"
• In reply to: Jeff Garzik: "Re: [PATCH] small rtc.c fix"
• Next in thread: Cesar Eduardo Barros: "Re: [PATCH] small rtc.c fix"
• Reply: Cesar Eduardo Barros: "Re: [PATCH] small rtc.c fix"
• Reply: Jeff Garzik: "Re: [PATCH] small rtc.c fix"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, May 19, 2000 at 04:34:37PM -0400, Jeff Garzik wrote:
> Cesar Eduardo Barros wrote:
> >
> > This patch fixes a simple thinko in my last rtc patch which could in completely
> > unlikely situations printk a wrong frequency value in rtc_dropped_irq (harmless
> > but wrong anyway).
> >
> > I'm still a bit wary about putting printk inside a spinlock critical region.
> > Comments?
>
> If you don't want the printk inside a spinlock, you can always grab the
> spinlock, store to a temporary, release the spinlock, and then do the
> printk.

OK, done.

> Also, make sure you increase the RTC when you do fixes as well as
> feature updates...

I think this change is too small to need to put my name on the header again.

-- 
Cesar Eduardo Barros
cesarb@nitnet.com.br
cesarb@dcc.ufrj.br
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: James Simmons: "Re: [linux-fbdev] Re: [PATCH] updated Mips Magnum frame buf"
• Previous message: Lorenzo Allegrucci: "Re: A variant of mlockall()"
• In reply to: Jeff Garzik: "Re: [PATCH] small rtc.c fix"
• Next in thread: Cesar Eduardo Barros: "Re: [PATCH] small rtc.c fix"
• Reply: Cesar Eduardo Barros: "Re: [PATCH] small rtc.c fix"
• Reply: Jeff Garzik: "Re: [PATCH] small rtc.c fix"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue May 23 2000 - 21:00:18 EST