Re: [patch] repost of netfilter/NIPQUAD patches

From: Olaf Titz (olaf@bigred.inka.de)
Date: Tue Apr 18 2000 - 17:45:25 EST


> __u32 x;
> addrstr_ipv4_t adr;
>
> printk ("%s", ipv4_ntoa(adr, x));
>
> Saves a few lines and is more readable.

Yes, but especially when using opaque types, make it clear that "adr"
is an output parameter:

> printk ("%s", ipv4_ntoa(&adr, x));
                          ^

Olaf

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:14 EST