Pavel Machek wrote:
>
> Hi!
>
> > > This simple patch makes maestro work in-kernel in 2.3.99-preX. Please
> > > apply.
> > >
> > > Pavel
> > > --- clean/drivers/sound/maestro.c Wed Feb 9 20:42:35 2000
> > > +++ linux/drivers/sound/maestro.c Sun Apr 16 20:41:50 2000
> > > @@ -3507,3 +3507,5 @@
> > >
> > > return 0;
> > > }
> > > +
> > > +__initcall(init_maestro);
> >
> > This should be module_init() not __initcall()...
> >
> > Following with the Linux kernel tradition you should not use a function
> > prefixed with '__' unless you have a reason NOT to use the "main
> > function".
>
> 2.2.X compatibility should be stripped from maestro, and then yes,
> module_init() would be the right way to go, along with
> module_exit. But just now...
Agree w/ Jes, you shouldn't strip 2.2.x compatibility unless the author
says it's ok.
If 2.2.x compatibility is desired you should create a patch for 2.2.x
which supports module_init/exit. If the older kernel version in
question supports initcall, implementing module_init is easy.
Jeff
-- Jeff Garzik | Nothing cures insomnia like the Building 1024 | realization that it's time to get up. MandrakeSoft, Inc. | -- random fortune- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:10 EST