Re: Fix for maestro in 2.3.99-preX

From: Pavel Machek (pavel@suse.cz)
Date: Mon Apr 17 2000 - 04:40:31 EST

Hi!

> > This simple patch makes maestro work in-kernel in 2.3.99-preX. Please
> > apply.
> >
> > Pavel
> > --- clean/drivers/sound/maestro.c Wed Feb 9 20:42:35 2000
> > +++ linux/drivers/sound/maestro.c Sun Apr 16 20:41:50 2000
> > @@ -3507,3 +3507,5 @@
> >
> > return 0;
> > }
> > +
> > +__initcall(init_maestro);
>
> This should be module_init() not __initcall()...
>
> Following with the Linux kernel tradition you should not use a function
> prefixed with '__' unless you have a reason NOT to use the "main
> function".

2.2.X compatibility should be stripped from maestro, and then yes,
module_init() would be the right way to go, along with
module_exit. But just now...

                                                                Pavel 

-- 
The best software in life is free (not shareware)!		Pavel
GCM d? s-: !g p?:+ au- a--@ w+ v- C++@ UL+++ L++ N++ E++ W--- M- Y- R+

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sun Apr 23 2000 - 21:00:10 EST