Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events

[Krzysztof Wilczyński]

Hello,

> > > +static struct pci_slot_attribute hotplug_slot_attr_uevent = {
> > > +	.attr = {.name = "uevent", .mode = S_IFREG | 0200},
> > > +	.show = NULL,
> > > +	.store = uevent_write_file
> > > +};
> > I think, you could use the __ATTR_WO() macro here.
> Use of the suggested macro is not appropriate

Just to expand on the "not appropriate" bit here.

Not wanting to change the name to have the _store suffix would be fine.

The __ATTR() would work here.  But, this file is old and wanting to
keep the style aligned with rest of it would be fine, too.

So, both of these reasons would be fine, to avoid using any new macro.

Thank you!

	Krzysztof