Re: [PATCH v2 1/1] PCI/hotplug: Add 'uevent' sysfs attribute to trigger slot events
From: Ramesh Errabolu
Date: Tue Apr 21 2026 - 17:41:18 EST
On 4/21/2026 12:13 PM, Krzysztof Wilczyński wrote:
Hello,Use of the suggested macro is not appropriate
+static struct pci_slot_attribute hotplug_slot_attr_uevent = {I think, you could use the __ATTR_WO() macro here.
+ .attr = {.name = "uevent", .mode = S_IFREG | 0200},
+ .show = NULL,
+ .store = uevent_write_file
+};
Thank you!
Krzysztof