Re: [PATCH v2 1/2] dt-bindings: iio: light: Avago APDS9306

[Krzysztof Kozlowski]

On 27/10/2023 10:55, Subhajit Ghosh wrote:
> 
>>>   
>>>   properties:
>>>     compatible:
>>> -    const: avago,apds9300
>>> +    oneOf:
>>
>> Drop
> Sorry, do you mean I should not use the "oneOf"?

Yep. You do not need it - you do not have more than one item.


>>
>>> +      - enum:
>>> +          - avago,apds9300
>>> +          - avago,apds9306
>>> +          - avago,apds9960
>>
>> I don't understand what is happening here. At all. Some compatibles are
>> moved, some are added, nothing explains why you are doing it.
>>
>>
>> Best regards,
>> Krzysztof
>>
> I have formatted the commit message wrongly, it will be fixed at once.
> I am trying to add the support for all the three sensors in the same schema file.

One commit does one logical thing. Moving things is one thing. Adding
things is another.

Best regards,
Krzysztof