RE: [PATCH v3.6 17/19] mwifiex: slight optimization of addr compare

From: Bing Zhao
Date: Tue Jan 07 2014 - 22:04:57 EST


Hi Ding,

> - if (memcmp(priv->curr_bss_params.bss_descriptor.mac_address,
> - ibss_coal_resp->bssid, ETH_ALEN)) {
> + if (!ether_addr_equal(priv->curr_bss_params.bss_descriptor.mac_address, ibss_coal_resp->bssid))

Still wrong... ;)

Have you actually run the checkpatch.pl script?

By the way, your subject prefix "PATCH v3.6" is confusing. It ought to be "PATCH v6", I guess.

Thanks,
Bing

¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶Ÿÿà -»+ƒùdš_