Re: [PATCH v2 3/3] rtc: Add MAX8998 rtc driver

From: Joonyoung Shim
Date: Mon Aug 02 2010 - 22:02:19 EST


On 8/3/2010 9:08 AM, Alessandro Zummo wrote:
> On Mon, 02 Aug 2010 16:35:07 +0900
> Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> wrote:
>
>> This adds support for the RTC provided by the Maxim 8998 chip. This
>> driver was tested on a GONI board by using the rtc-test application from
>> the Documentation/rtc.txt.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>> Acked-by: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
>
> Seems nice. I'd add rtc_valid_tm where appropriate.
> And maybe free that irq you requested ;)
>

Right, i missed.

> pending those changes, you have my
>
> Acked-by: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
>
>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/