Re: [PATCH v2 3/3] rtc: Add MAX8998 rtc driver

[Alessandro Zummo]

On Mon, 02 Aug 2010 16:35:07 +0900
Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> wrote:

> This adds support for the RTC provided by the Maxim 8998 chip. This
> driver was tested on a GONI board by using the rtc-test application from
> the Documentation/rtc.txt.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Acked-by: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>

 Seems nice. I'd add rtc_valid_tm where appropriate.
 And maybe free that irq you requested ;)

 pending those changes, you have my 

  Acked-by: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>


-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/