Re: [PATCH 0/6 v4] KVM support for 1GB pages

From: Avi Kivity
Date: Tue Jul 07 2009 - 13:02:45 EST


On 07/07/2009 07:52 PM, Joerg Roedel wrote:
I would really like to have shadow 1GB work, or at least gain some
understanding of why it doesn't.

Can you detail the changes compared to the previous round?

Until now I addressed the review comments from the previous round. The
biggest change is patch #4 which was completly rewritten.
I understand that it would be nicer to have shadow paging working too.
But since most users will use this feature only on processors with
nested paging (only processors with nested paging support gbpages) I
don't think it should be a show-stopper. YMMV.

Right. I don't think 1GB+shadow is useful in its own right. It's not a barrier for merging (but still very desirable). I do want more information on how it fails though.

Anyway, I will further try to get shadow paging support running and
stable.

Great, thanks.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/