Re: [PATCH 0/6 v4] KVM support for 1GB pages

From: Joerg Roedel
Date: Tue Jul 07 2009 - 12:53:22 EST


On Tue, Jul 07, 2009 at 07:47:14PM +0300, Avi Kivity wrote:
> On 07/07/2009 07:41 PM, Joerg Roedel wrote:
> >Hi,
> >
> >this is the forth version of the patches for KVM to support 1GB pages.
> >This code still only can make use of 1GB pages with nested paging
> >enabled. I will give the shadow paging code another debug round soon.
> >Please comment or consider to apply these patches.
> >
>
> I would really like to have shadow 1GB work, or at least gain some
> understanding of why it doesn't.
>
> Can you detail the changes compared to the previous round?

Until now I addressed the review comments from the previous round. The
biggest change is patch #4 which was completly rewritten.
I understand that it would be nicer to have shadow paging working too.
But since most users will use this feature only on processors with
nested paging (only processors with nested paging support gbpages) I
don't think it should be a show-stopper. YMMV.
Anyway, I will further try to get shadow paging support running and
stable.

Joerg

--
| Advanced Micro Devices GmbH
Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei München
System |
Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
| Registergericht München, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/