Re: [PATCH 1/4][RFC] tracing: add event trace infrastructure

[Steven Rostedt]

On Tue, 24 Feb 2009, Ingo Molnar wrote:

> 
> * Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Tue, 24 Feb 2009 14:33:45 -0500
> > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > 
> > > +#define DECLARE_TRACE_FMT(call, proto, args, fmt, fmt_args)		\
> > > +static void ftrace_event_##call(proto)					\
> > > +{									\
> > > +	event_trace_printk(_RET_IP_, "(%s) " fmt "\n", #call, fmt_args); \
> > > +}									\
> > 
> > <anal>This macro emits a definition, not a declaration.</anal>
> 
> yes indeed :) It got modified from one that emitted a 
> declaration to also emit a definition and the name was not 
> converted.

Yes, I was just adding a modification of DECLARE_TRACE which was indeed a 
declare, but converted it to DECLARE_TRACE_FMT.

Would DEFINE_TRACE_FMT(...) be better?

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/