Re: [PATCH 0/4][RFC] event tracer

[Steven Rostedt]

On Tue, 24 Feb 2009, Peter Zijlstra wrote:

> On Tue, 2009-02-24 at 14:33 -0500, Steven Rostedt wrote:
> 
> >  DECLARE_TRACE_FMT(sched_kthread_stop,
> >         TPPROTO(struct task_struct *t),
> >                   TPARGS(t),
> >                    "task %s:%d", TPARGS(t->comm, t->pid));
> 
> Consistency would require something like:
> 
> DECLARE_TRACE_FMT(sched_kthread_stop,
> 		  TPPROTO(struct task_struct *t),
> 		  TPARGS(t),
> 		  TPFMT("task %s:%d", t->comm, t->pid));
> 
> I seem to remember Jason proposing something like this in the past.

Hmm, I'll have to look at that. (althought I was going to use a different 
TPARGS for the format args.)

I have, for now:

	event_printk("(%s)" fmt "\n", #call, fmtargs);

I guess I can redefine the TPFMT too.

#undef TPFMT
#define TPFMT(fmt, args...) \
	"(%s)" fmt "\n", #call, ##args

and then I could do

	event_printk(fmt);

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/