Re: [PATCH] Adds support for TEA5767 chipset on V4L

[Jean Delvare]

Hi Mauro,

> PS 3: There were some I2C changes that affected V4L on 2.6.12-rc6-mm1.
> Now, it is necessary to use probe option in tuner to have its I2C
> addresses recognized by V4L. New patches will come to correct this
> behavior.

Which i2c patch please? The changes I made should not cause any trouble
to V4L drivers. If they do this is a bug, please report it as such.

Also, a comment on your patch (which I didn't actually review, as I do
not feel qualified to do so):

> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
> +#include "tuner.h"
> +#include "i2c-compat.h"
> +#else
> +#include <media/tuner.h>
> +#endif

No such test please, it is useless. This is Linux 2.6.x, no need to
check this.

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/