> The following is definitely wrong, you need to pass
> pcibios_align_resource and pcidev in that order.
Thanks, I'll do. But the question persists - why did not the driver
maintainer do this?
> Sergey Kubushin wrote:
> > diff -urN linux-2.3.30pre5.orig/drivers/sound/sonicvibes.c linux-2.3.30pre5/drivers/sound/sonicvibes.c
> > --- linux-2.3.30pre5.orig/drivers/sound/sonicvibes.c Fri Dec 3 12:52:16 1999
> > +++ linux-2.3.30pre5/drivers/sound/sonicvibes.c Fri Dec 3 13:54:13 1999
> > @@ -2458,7 +2458,7 @@
> > memcpy(ddmaname, sv_ddma_name, ddmanamelen);
> > pcidev->resource[RESOURCE_DDMA].name = ddmaname;
> > if (allocate_resource(&ioport_resource, pcidev->resource+RESOURCE_DDMA,
> > - 2*SV_EXTENT_DMA, 0x1000, 0x10000-2*SV_EXTENT_DMA, 1024, pcidev)) {
> > + 2*SV_EXTENT_DMA, 0x1000, 0x10000-2*SV_EXTENT_DMA, 1024, pcidev, NULL)) {
> > pcidev->resource[RESOURCE_DDMA].name = NULL;
> > kfree(ddmaname);
> > printk(KERN_ERR "sv: cannot allocate DDMA controller io ports\n");
> > === Cut ===
> --
> Jeff Garzik | Just once, I wish we would encounter
> Building 1024 | an alien menace that wasn't immune to
> MandrakeSoft, Inc. | bullets. -- The Brigadier, "Dr. Who"
>
===========================================================================
Sergey Kubushin aka the Tamer < > The impossible we do immediately.
e-mail: ksi@ksi-linux.com SK320-RIPE < > Miracles require 24-hour notice.
===========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/