Re: [PATCH] device file support for /proc filesystem

Alexander Viro (viro@math.psu.edu)
Wed, 17 Nov 1999 14:57:56 -0500 (EST)


On Wed, 17 Nov 1999, Chris wrote:

> On Wed, 17 Nov 1999, Alexander Viro wrote:
>
> > On Wed, 17 Nov 1999, Jaroslav Kysela wrote:
> >
> > > Nothing. Kernels from 2.3.27 are not supported yet. The new /proc code is
> > > not able to create devices inside /proc directory :-((
> > >
> > > It would be good to include the following patch (or similar) into kernel.
> > > Please, let me know, if someone will do it, because I'm not checking 2.3
> > > kernel changes every day.
> >
> > Patch is more or less OK, except that it should really use
> > init_special_inode() (you forgot to set inode->i_op). I have an equivalent
> > queued, it's waiting for Linus coming back.
>
> With this patch applied to my stock 2.3.28, i get this in my root
> directory:
>
> unitee:~# ls -l /proc
> ?-------w- 16 root root 3223071008 Nov 17 12:36 /proc
>
> Any idea why?

Erm... because you didn't modify initializer for proc_root and didn't do
obvious reordering of the fields? Inserting something into the
middle of a structure hurts if you have static intializers. BTW, could I
look at the rest of patches you applied? Somehow I feel that there are
static entries too. IOW, need of cleanup.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/