IrDA doesn't export required symbols in 2.2.14-pre2

David Woodhouse (David.Woodhouse@mvhi.com)
Wed, 10 Nov 1999 09:04:44 +0000

If you build all the IR support as modules, some required symbols aren't
exported.

This helps, but the Makefile still doesn't look right w.r.t. deciding how to
build irport.o - it needs something like the sound Makefile.

Index: Makefile
===================================================================
RCS file: /cvs/linux/drivers/net/irda/Makefile,v
retrieving revision 1.3
diff -u -w -u -r1.3 Makefile
--- Makefile 1999/10/07 12:44:31 1.3
+++ Makefile 1999/11/10 09:03:40
@@ -21,29 +21,13 @@
endif

ifeq ($(CONFIG_IRPORT_SIR),y)
-L_OBJS += irport.o
+LX_OBJS += irport.o
else
ifeq ($(CONFIG_IRPORT_SIR),m)
- M_OBJS += irport.o
+ MX_OBJS += irport.o
endif
endif

-ifeq ($(CONFIG_IRPORT_SIR),y)
-L_OBJS += irport.o
-else
- ifeq ($(CONFIG_IRPORT_SIR),m)
- M_OBJS += irport.o
- endif
-endif
-
-ifeq ($(CONFIG_IRPORT_SIR),y)
-L_OBJS += irport.o
-else
- ifeq ($(CONFIG_IRPORT_SIR),m)
- M_OBJS += irport.o
- endif
-endif
-
ifeq ($(CONFIG_NSC_FIR),y)
L_OBJS += pc87108.o
else
@@ -61,26 +45,12 @@
endif

ifeq ($(CONFIG_SHARP_FIR),y)
-L_OBJS += uircc.o irport.o
+L_OBJS += uircc.o
+LX_OBJS += irport.o
else
ifeq ($(CONFIG_SHARP_FIR),m)
- M_OBJS += uircc.o irport.o
- endif
-endif
-
-ifeq ($(CONFIG_TOSHIBA_FIR),y)
-L_OBJS += toshoboe.o
-else
- ifeq ($(CONFIG_TOSHIBA_FIR),m)
- M_OBJS += toshoboe.o
- endif
-endif
-
-ifeq ($(CONFIG_TOSHIBA_FIR),y)
-L_OBJS += toshoboe.o
-else
- ifeq ($(CONFIG_TOSHIBA_FIR),m)
- M_OBJS += toshoboe.o
+ M_OBJS += uircc.o
+ MX_OBJS += irport.o
endif
endif

@@ -93,10 +63,12 @@
endif

ifeq ($(CONFIG_SMC_IRCC_FIR),y)
-L_OBJS += irport.o smc-ircc.o
+L_OBJS += smc-ircc.o
+LX_OBJS += irport.o
else
ifeq ($(CONFIG_SMC_IRCC_FIR),m)
- M_OBJS += irport.o smc-ircc.o
+ M_OBJS += smc-ircc.o
+ MX_OBJS += irport.o
endif
endif

Index: irport.c
===================================================================
RCS file: /cvs/linux/drivers/net/irda/irport.c,v
retrieving revision 1.4
diff -u -w -u -r1.4 irport.c
--- irport.c 1999/06/29 14:31:11 1.4
+++ irport.c 1999/11/10 09:03:40
@@ -58,6 +58,8 @@
#include <net/irda/wrapper.h>
#include <net/irda/irport.h>

+EXPORT_SYMBOL(irport_change_speed);
+
#define IO_EXTENT 8

/*

---- ---- ----
David Woodhouse David.Woodhouse@mvhi.com Office: (+44) 1223 810302
Project Leader, Process Information Systems Mobile: (+44) 7976 658355
Axiom (Cambridge) Ltd., Swaffham Bulbeck, Cambridge, CB5 0NA, UK.
finger dwmw2@ferret.lmh.ox.ac.uk for PGP key.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/