Re: [patch] highmem /proc/*/statm fix (2.3.26)

Ingo Molnar (mingo@chiara.csoma.elte.hu)
Wed, 10 Nov 1999 09:06:45 +0100 (CET)


On Tue, 9 Nov 1999, Andrea Arcangeli wrote:

> - if (MAP_NR(pte_page(page)) >= max_mapnr)
> + if (pte_pagenr(page) >= max_mapnr)
> continue;
> - if (page_count(mem_map + MAP_NR(pte_page(page))) > 1)
> + if (page_count(pte_page(page)) > 1)

whoops, nasty. The bug went unnoticed because MAP_NR forces all arguments
to 'unsigned long', this hides the bug that we are passing a 'struct page
*'. I've re-checked all places that used pte_page() prior to the highmem
chances, and all appears to be fine now. Thanks.

Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/