Re: [PATCH] four warnings and a patch [AGAIN]

Matthew Wilcox (Matthew.Wilcox@genedata.com)
Fri, 29 Oct 1999 11:45:57 +0200

On Thu, Oct 28, 1999 at 06:37:44PM -0400, Dennis Hou wrote:
> Thanks to all who replied; I feel enlightened now (and foolish, for
> overlooking the macro.) You guys certainly know how to scare off by
> numbers. ;-)
>
> This time, it just puts an #ifdef/#endif (same as those around
> EI_SHIFT(x).)

I don't think this is a good idea. Take a look at the Mach sources
sometime for what happens if you allow this sort of thing. For example:
scsi_ncr53c700.c contains 568 preprocessor lines out of a total of 3430.
It's real spaghetti code.

-- 
Matthew Wilcox <willy@bofh.ai>
"Windows and MacOS are products, contrived by engineers in the service of
specific companies. Unix, by contrast, is not so much a product as it is a
painstakingly compiled oral history of the hacker subculture." - N Stephenson


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/