Re: access_ok inside kernelspace

Tigran Aivazian (tigran@sco.COM)
Tue, 19 Oct 1999 11:59:57 +0100 (BST)


On Tue, 19 Oct 1999, Tigran Aivazian wrote:

> On Tue, 19 Oct 1999, Tigran Aivazian wrote:
> > I presume there are none (on i386 architecture)?
> this assumption is wrong - there are a couple of cases where sys_XXX()
> functions are called - sys_oldumount(), sys_creat().But there is no reason
> why they shouldn't be changed to use inlined _syscallX()'d things to be
> consistent, is there?

actually (talking to myself?) there is a good reason not to do so.
Performance. So, my statement should be slightly changed to "All calls to
system calls (except where impossible, e.g. fork()/pause() should go
through sys_XXX() functions"

E.g. exec_modprobe() of kernel/kmod.c calls inlined close(i) while it
could just do sys_close(i).

Regards,
Tigran.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/