Re: Megaraid versus Initio INI-A100

Paul Gortmaker (p_gortmaker@yahoo.com)
Mon, 18 Oct 1999 12:15:45 -0700 (PDT)

Alan Cox wrote:
>
> > The Megaraid-scsi driver defines SCB_COMPLETE as 0x4 while the Initio
> > INI-A100 defines it as 0x00. (megaraid.h vs inia100.h in drivers/scsi)
> >
> > If both cards are selected, drivers/scsi/hosts.c includes both
> > header-files. Should this clash be resolved or is it just harmless?
>
> It is probably harmless but it is untidy. Perhaps rename one of them and
> send me a patch ?

In hosts.c HOSTS_C (or something like that) is defined so that driver
header files can avoid this while keeping commonly used names, i.e:

#ifdef HOSTS_C
... only the stuff required for compiling hosts.c ...
#else
... all the private #defines to be seen only by my driver
#endif

This saves trying to come up with 1001 unique names for things
like SCB_COMPLETE.

Paul.

__________________________________________________
Do You Yahoo!?
Bid and sell for free at http://auctions.yahoo.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/