Re: [PATCH] cdda reading

laredo@gnu.org
Mon, 11 Oct 1999 14:45:36 -0400 (EDT)

> Just looking over this patch, it would seem a few things are off a bit:
>
> -= 1 =-
>
> - if ((cgc.buffer = (char *)kmalloc(CD_FRAMESIZE_RAW*ra.nframes,
> + if ((cgc.buffer = (char *)kmalloc(CD_FRAMESIZE_RAW*8,
>
> doesn't this change it from kmalloc'ing a ra.nframes frame block to an 8
> frame block?

Of course at ~16k, this is a lot safer than 75 blocks which would make kmalloc
go "boom". 75 blocks is more than 140K. Might be better to set the limit
closer to 128K for a bit more "efficiency." 48 blocks would be a bit more
"ideal" for the available size of a kmalloc (128k). The fewer commands sent
to the drive the better IMO.

-- Nathan Laredo
laredo@gnu.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/