Re: AHA1542 driver is buggy

Guest section DW (dwguest@win.tue.nl)
Tue, 5 Oct 1999 12:10:57 +0200 (MET DST)


From: ssd@nevets.oau.org (Steven S. Dick)

I have an aha1542, and it appears the driver is still buggy.
I don't think the reset code in the driver has ever worked correctly.

I have a couple of cd's with bad scratches; when any of my scsi drives
attempts to read over a scratch, the 1542 goes into a reset loop.
Before the following patch, it would reset a couple of times and then
die with "Panic: freeing free memory" or something close...

(this patch against 2.2.12, but probably works in others too)

--- linux/drivers/scsi/aha1542.c.orig Mon Aug 9 15:04:39 1999
+++ linux/drivers/scsi/aha1542.c Sun Sep 26 12:27:27 1999
@@ -482,7 +482,10 @@
}

my_done = SCtmp->scsi_done;
- if (SCtmp->host_scribble) scsi_free(SCtmp->host_scribble, 512);
+ if (SCtmp->host_scribble) {
+ scsi_free(SCtmp->host_scribble, 512);
+ SCtmp->host_scribble = 0;
+ }

/* Fetch the sense data, and tuck it away, in the required slot. The
Adaptec automatically fetches it, and there is no guarantee that

You will notice that this patch is part of aha1542.c as I distributed
it a year or so ago.

With this patch, the kernel no longer panics, and an I/O error is returned
to the application. Unfortunately, after this, the device no longer
responds, and any access to the device causes the process to block but
still remain killable. I fear I've fixed a symptom, and not the real bug.
(I.e., it still hurts, but the patient no longer dies.)

Yes. I think I fixed a few more symptoms, but am still unhappy about
the driver, that is why it is sitting in directories like
ftp://ftp.XX.kernel.org/pub/linux/kernel/people/aeb
or so.
Can you report on that driver ?

Andries - aeb@cwi.nl

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/